From dc4f72debbd8cb39c9715842598ff3241faf9f23 Mon Sep 17 00:00:00 2001 From: John-Michael Faircloth Date: Thu, 8 Jun 2023 10:25:58 -0500 Subject: [PATCH] Revert "Test that overwrite env var works in nested action (#453)" (#464) This reverts commit d27529ebdeec73e7347123218eca231e751860c5. --- .github/workflows/build.yml | 15 --------------- integrationTests/e2e/e2e.test.js | 1 - integrationTests/e2e/setup.js | 12 ------------ 3 files changed, 28 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bdfd9ae..50b68b9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -166,21 +166,6 @@ jobs: run: npm run test:integration:e2e env: OTHER_SECRET_OUTPUT: ${{ steps.kv-secrets.outputs.otherSecret }} - - - name: Test Vault Action Overwrites Env Vars In Subsequent Action (part 1/2) - uses: ./ - with: - url: http://localhost:8200/ - token: testtoken - secrets: | - secret/data/test secret | SUBSEQUENT_TEST_SECRET; - - name: Test Vault Action Overwrites Env Vars In Subsequent Action (part 2/2) - uses: ./ - with: - url: http://localhost:8200/ - token: testtoken - secrets: | - secret/data/subsequent-test secret | SUBSEQUENT_TEST_SECRET; e2e-tls: runs-on: ubuntu-latest diff --git a/integrationTests/e2e/e2e.test.js b/integrationTests/e2e/e2e.test.js index 6495d14..c5ed5af 100644 --- a/integrationTests/e2e/e2e.test.js +++ b/integrationTests/e2e/e2e.test.js @@ -9,6 +9,5 @@ describe('e2e', () => { expect(process.env.OTHERALTSECRET).toBe("OTHERCUSTOMSECRET"); expect(process.env.FOO).toBe("bar"); expect(process.env.NAMED_CUBBYSECRET).toBe("zap"); - expect(process.env.SUBSEQUENT_TEST_SECRET).toBe("SUBSEQUENT_TEST_SECRET"); }); }); diff --git a/integrationTests/e2e/setup.js b/integrationTests/e2e/setup.js index 96f2295..846a9ed 100644 --- a/integrationTests/e2e/setup.js +++ b/integrationTests/e2e/setup.js @@ -76,18 +76,6 @@ const vaultToken = `${process.env.VAULT_TOKEN}` === undefined ? `${process.env.V zip: 'zap', }, }); - - await got(`http://${vaultUrl}/v1/secret/data/subsequent-test`, { - method: 'POST', - headers: { - 'X-Vault-Token': vaultToken, - }, - json: { - data: { - secret: 'SUBSEQUENT_TEST_SECRET', - }, - }, - }); } catch (error) { console.log(error); process.exit(1);