actions/vault-action
5
0
Fork 0
mirror of https://github.com/hashicorp/vault-action.git synced 2025-11-06 23:06:54 +00:00
Code Activity Actions

fix: replace all dot chars during normalization (#580)

Browse source 
* fix: replace all dot chars during normalization

* changelog
This commit is contained in:
John-Michael Faircloth 2025-05-14 09:32:58 -05:00 committed by GitHub
parent 4d5899dd0e
commit b022ecdb0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
CHANGELOG.md
View file

@ -1,3 +1,9 @@
## Unreleased
Bugs:
* replace all dot chars during normalization (https://github.com/hashicorp/vault-action/pull/580)
## 3.3.0 (March 3, 2025) ## 3.3.0 (March 3, 2025)
Features: Features:

2
dist/index.js vendored
View file

@ -19309,7 +19309,7 @@ module.exports = {
*/ */
function normalizeOutputKey(dataKey, upperCase = false) { function normalizeOutputKey(dataKey, upperCase = false) {
let outputKey = dataKey let outputKey = dataKey
.replace(".", "__") .replaceAll(".", "__")
.replace(new RegExp("-", "g"), "") .replace(new RegExp("-", "g"), "")
.replace(/[^\p{L}\p{N}_-]/gu, ""); .replace(/[^\p{L}\p{N}_-]/gu, "");
if (upperCase) { if (upperCase) {

18
integrationTests/basic/integration.test.js
View file

@ -39,6 +39,14 @@ describe('integration', () => {
body: `{"data":{"secret.foo":"SUPERSECRET"}}` body: `{"data":{"secret.foo":"SUPERSECRET"}}`
}); });
await got(`${vaultUrl}/v1/secret/data/test-with-multi-dot-chars`, {
method: 'POST',
headers: {
'X-Vault-Token': vaultToken,
},
body: `{"data":{"secret.foo.bar":"SUPERSECRET"}}`
});
await got(`${vaultUrl}/v1/secret/data/nested/test`, { await got(`${vaultUrl}/v1/secret/data/nested/test`, {
method: 'POST', method: 'POST',
headers: { headers: {
@ -293,6 +301,16 @@ describe('integration', () => {
expect(core.exportVariable).toBeCalledWith('SECRET__FOO', 'SUPERSECRET'); expect(core.exportVariable).toBeCalledWith('SECRET__FOO', 'SUPERSECRET');
}); });
it('get secrets with multiple dot chars', async () => {
mockInput(`secret/data/test-with-multi-dot-chars * ;`);
await exportSecrets();
expect(core.exportVariable).toBeCalledTimes(1);
expect(core.exportVariable).toBeCalledWith('SECRET__FOO__BAR', 'SUPERSECRET');
});
it('get wildcard secrets', async () => { it('get wildcard secrets', async () => {
mockInput(`secret/data/test * ;`); mockInput(`secret/data/test * ;`);

2
src/utils.js
View file

@ -5,7 +5,7 @@
*/ */
function normalizeOutputKey(dataKey, upperCase = false) { function normalizeOutputKey(dataKey, upperCase = false) {
let outputKey = dataKey let outputKey = dataKey
.replace(".", "__") .replaceAll(".", "__")
.replace(new RegExp("-", "g"), "") .replace(new RegExp("-", "g"), "")
.replace(/[^\p{L}\p{N}_-]/gu, ""); .replace(/[^\p{L}\p{N}_-]/gu, "");
if (upperCase) { if (upperCase) {