From 6ee4dd3797faa8f152e3dcea855bfd607a7171cb Mon Sep 17 00:00:00 2001 From: Christopher Swenson Date: Wed, 15 Jun 2022 14:50:07 -0700 Subject: [PATCH] Set node version to v16.14.0 to workaround node/npm bug (#335) Node 16.14.2 thinks the `package-lock.json` is out of sync when it is not. https://github.com/npm/cli/issues/4660 --- .github/workflows/build.yml | 25 ++++++++++++------------- package-lock.json | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f4fa57b..4a48f95 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,9 +12,9 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '' + node-version: '16.14.0' - name: Setup NPM Cache uses: actions/cache@v1 @@ -42,9 +42,9 @@ jobs: - name: Run docker-compose run: docker-compose up -d vault - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '' + node-version: '16.14.0' - name: Setup NPM Cache uses: actions/cache@v1 @@ -78,9 +78,9 @@ jobs: env: VAULT_LICENSE_CI: ${{ secrets.VAULT_LICENSE_CI }} - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '' + node-version: '16.14.0' - name: Setup NPM Cache uses: actions/cache@v1 @@ -112,9 +112,9 @@ jobs: - name: Run docker-compose run: docker-compose up -d vault - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '' + node-version: '16.14.0' - name: Setup NPM Cache uses: actions/cache@v1 @@ -180,9 +180,9 @@ jobs: - name: Run docker-compose run: docker-compose up -d vault-tls - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: - node-version: '' + node-version: '16.14.0' - name: Setup NPM Cache uses: actions/cache@v1 @@ -269,9 +269,9 @@ jobs: # needs: [build, integration, e2e] # steps: # - uses: actions/checkout@v1 -# - uses: actions/setup-node@v1 +# - uses: actions/setup-node@v3 # with: -# node-version: '' +# node-version: '16.14.0' # - name: setup npm cache # uses: actions/cache@v1 # with: @@ -287,4 +287,3 @@ jobs: # env: # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - diff --git a/package-lock.json b/package-lock.json index 36ad76b..aaa8467 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13629,6 +13629,12 @@ "inBundle": true, "license": "ISC" }, + "node_modules/npm/node_modules/hosted-git-info": { + "version": "2.8.8", + "dev": true, + "inBundle": true, + "license": "ISC" + }, "node_modules/npm/node_modules/http-cache-semantics": { "version": "3.8.1", "dev": true, @@ -13755,6 +13761,15 @@ "inBundle": true, "license": "ISC" }, + "node_modules/npm/node_modules/ini": { + "version": "1.3.5", + "dev": true, + "inBundle": true, + "license": "ISC", + "engines": { + "node": "*" + } + }, "node_modules/npm/node_modules/init-package-json": { "version": "1.10.3", "dev": true, @@ -15029,6 +15044,12 @@ "node": ">=4" } }, + "node_modules/npm/node_modules/path-parse": { + "version": "1.0.6", + "dev": true, + "inBundle": true, + "license": "MIT" + }, "node_modules/npm/node_modules/performance-now": { "version": "2.1.0", "dev": true, @@ -29839,6 +29860,11 @@ "bundled": true, "dev": true }, + "hosted-git-info": { + "version": "2.8.8", + "bundled": true, + "dev": true + }, "http-cache-semantics": { "version": "3.8.1", "bundled": true, @@ -29930,6 +29956,11 @@ "bundled": true, "dev": true }, + "ini": { + "version": "1.3.5", + "bundled": true, + "dev": true + }, "init-package-json": { "version": "1.10.3", "bundled": true, @@ -30935,6 +30966,11 @@ "bundled": true, "dev": true }, + "path-parse": { + "version": "1.0.6", + "bundled": true, + "dev": true + }, "performance-now": { "version": "2.1.0", "bundled": true,