mirror of
https://github.com/hashicorp/vault-action.git
synced 2025-11-14 18:13:45 +00:00
make "role" input optional
Per Vault documentation it doesn't have to be provided, and the auth provider's "default_role" parameter is required precisely for this case. https://www.vaultproject.io/api/auth/jwt
This commit is contained in:
parent
67281159df
commit
4bd533450e
2 changed files with 10 additions and 1 deletions
|
|
@ -233,6 +233,15 @@ describe('jwt auth', () => {
|
||||||
expect(core.exportVariable).toBeCalledWith('SECRET', 'SUPERSECRET');
|
expect(core.exportVariable).toBeCalledWith('SECRET', 'SUPERSECRET');
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('successfully authenticates as default role without specifying it', async () => {
|
||||||
|
when(core.getInput)
|
||||||
|
.calledWith('role')
|
||||||
|
.mockReturnValueOnce(null);
|
||||||
|
|
||||||
|
await exportSecrets();
|
||||||
|
expect(core.exportVariable).toBeCalledWith('SECRET', 'SUPERSECRET');
|
||||||
|
})
|
||||||
|
|
||||||
});
|
});
|
||||||
|
|
||||||
});
|
});
|
||||||
|
|
|
||||||
|
|
@ -25,7 +25,7 @@ async function retrieveToken(method, client) {
|
||||||
case 'jwt': {
|
case 'jwt': {
|
||||||
/** @type {string} */
|
/** @type {string} */
|
||||||
let jwt;
|
let jwt;
|
||||||
const role = core.getInput('role', { required: true });
|
const role = core.getInput('role', { required: false });
|
||||||
const privateKeyRaw = core.getInput('jwtPrivateKey', { required: false });
|
const privateKeyRaw = core.getInput('jwtPrivateKey', { required: false });
|
||||||
const privateKey = Buffer.from(privateKeyRaw, 'base64').toString();
|
const privateKey = Buffer.from(privateKeyRaw, 'base64').toString();
|
||||||
const keyPassword = core.getInput('jwtKeyPassword', { required: false });
|
const keyPassword = core.getInput('jwtKeyPassword', { required: false });
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue