From 4561f9e26e87066e16c930b1f8b2fc7310475df6 Mon Sep 17 00:00:00 2001 From: Richard Simpson Date: Wed, 11 Mar 2020 14:16:21 -0500 Subject: [PATCH] docs: fix typo and clarify masking --- README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index d6df37b..9b3d087 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ By default, this action pulls from [Version 2](https://www.vaultproject.io/docs - [Adding Extra Headers](#adding-extra-headers) - [Vault Enterprise Features](#vault-enterprise-features) - [Namespace](#namespace) -- [Mashing - Secrets in Logs](#mashing---secrets-in-logs) +- [Masking - Hidding Secrets from Logs](#masking---hidding-secrets-from-logs) @@ -258,6 +258,7 @@ steps: ci npm_token ``` -## Mashing - Secrets in Logs +## Masking - Hidding Secrets from Logs -This action uses Github Action's built in masking, so all variables will automatically be masked (aka hidden) if printed to the console or to logs. +This action uses GitHub Action's built-in masking, so all variables will automatically be masked (aka hidden) if printed to the console or to logs. +**This only obscures secrets from output logs.** If someone has the ability to edit your workflows, then they are able to read and therefore write secrets to somewhere else just like normal GitHub Secrets.