mirror of
https://github.com/jdx/mise-action.git
synced 2026-05-14 13:50:33 +00:00
f1c6089fba
## Summary Refs #382 (Problem 1). The default cache key template placed `file_hash` before conditional segments (`version`, `mise_env`, `install_args_hash`). Because `@actions/cache` `restoreCache` performs prefix matching on the primary key, a key without optional trailing segments was always a prefix of a key with them, causing different workflow configurations to restore each other's caches unintentionally. ## The bug Old template: ``` {{cache_key_prefix}}-{{platform}}-{{file_hash}}{{#if version}}-{{version}}{{/if}}{{#if mise_env}}-{{mise_env}}{{/if}}{{#if install_args_hash}}-{{install_args_hash}}{{/if}} ``` Example: Workflow A (no `install_args`) produces key `mise-v0-linux-x64-<hash>`, which is a prefix of Workflow B's key `mise-v0-linux-x64-<hash>-<args_hash>`. If only B's cache exists, A restores it via prefix match. ## The fix Move `file_hash` to the end of the template so it acts as a terminator: ``` {{cache_key_prefix}}-{{platform}}{{#if version}}-{{version}}{{/if}}{{#if mise_env}}-{{mise_env}}{{/if}}{{#if install_args_hash}}-{{install_args_hash}}{{/if}}-{{file_hash}} ``` Since `file_hash` is always present, no valid cache key can be a prefix of another. Also bumps `cache_key_prefix` default from `mise-v0` to `mise-v1` (in both `src/index.ts` and `action.yml`) to intentionally invalidate existing caches that may have been saved under incorrect prefix-matched keys. ## Changes - `src/index.ts` L43: Reorder `DEFAULT_CACHE_KEY_TEMPLATE` — move `file_hash` to end - `src/index.ts` L432: Bump fallback `cache_key_prefix` from `mise-v0` to `mise-v1` - `action.yml` L46: Bump default `cache_key_prefix` from `mise-v0` to `mise-v1` - Rebuilt `dist/` |
||
|---|---|---|
| .. | ||
| index.js | ||
| index.js.map | ||
| licenses.txt | ||
| sourcemap-register.js | ||