From 9936e43d4785d8f13c5c2bf0a25483db813c4184 Mon Sep 17 00:00:00 2001 From: Yann Hamon Date: Sat, 14 Nov 2020 15:57:39 +0100 Subject: [PATCH] opts should not be a pointer --- cmd/kubeconform/main.go | 2 +- pkg/validator/validator.go | 4 ++-- pkg/validator/validator_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/kubeconform/main.go b/cmd/kubeconform/main.go index fb2ccdb..e9f1a71 100644 --- a/cmd/kubeconform/main.go +++ b/cmd/kubeconform/main.go @@ -65,7 +65,7 @@ func realMain() int { return 1 } - v := validator.New(cfg.SchemaLocations, &validator.Opts{ + v := validator.New(cfg.SchemaLocations, validator.Opts{ SkipTLS: cfg.SkipTLS, SkipKinds: cfg.SkipKinds, RejectKinds: cfg.RejectKinds, diff --git a/pkg/validator/validator.go b/pkg/validator/validator.go index 6cc1914..12d451e 100644 --- a/pkg/validator/validator.go +++ b/pkg/validator/validator.go @@ -22,7 +22,7 @@ const ( ) type Validator struct { - opts *Opts + opts Opts schemaCache *cache.SchemaCache schemaDownload func(registries []registry.Registry, kind, version, k8sVersion string) (*gojsonschema.Schema, error) regs []registry.Registry @@ -58,7 +58,7 @@ func downloadSchema(registries []registry.Registry, kind, version, k8sVersion st return nil, nil // No schema found - we don't consider it an error, resource will be skipped } -func New(schemaLocations []string, opts *Opts) *Validator { +func New(schemaLocations []string, opts Opts) *Validator { registries := []registry.Registry{} for _, schemaLocation := range schemaLocations { registries = append(registries, registry.New(schemaLocation, opts.Strict, opts.SkipTLS)) diff --git a/pkg/validator/validator_test.go b/pkg/validator/validator_test.go index b7259b3..2872fec 100644 --- a/pkg/validator/validator_test.go +++ b/pkg/validator/validator_test.go @@ -135,7 +135,7 @@ lastName: bar }, } { v := Validator{ - opts: &Opts{ + opts: Opts{ SkipKinds: map[string]bool{}, RejectKinds: map[string]bool{}, },