From 928d694e66c3cb8672a9c0b6833b7fe9b756584a Mon Sep 17 00:00:00 2001
From: Yann Hamon <yann@mandragor.org>
Date: Sat, 30 May 2020 20:08:51 +0200
Subject: [PATCH] differentiate between an invalid resource and a validation
 error in output

---
 pkg/output/json.go | 12 +++++++++++-
 pkg/output/text.go |  9 +++++----
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/pkg/output/json.go b/pkg/output/json.go
index 5c74dbf..f8d0253 100644
--- a/pkg/output/json.go
+++ b/pkg/output/json.go
@@ -3,6 +3,7 @@ package output
 import (
 	"encoding/json"
 	"fmt"
+	"github.com/yannh/kubeconform/pkg/validator"
 )
 
 type result struct {
@@ -26,10 +27,16 @@ func NewJSONOutput(withSummary bool) Output{
 func (o *JSONOutput) Write(filename string,err error, skipped bool) {
 	status := "VALID"
 	msg := ""
+
 	if err != nil {
-		status = "INVALID"
 		msg = err.Error()
+		if _, ok := err.(validator.InvalidResourceError); ok {
+			status = "INVALID"
+		} else {
+			status = "ERROR"
+		}
 	}
+
 	if skipped {
 		status = "SKIPPED"
 	}
@@ -47,6 +54,7 @@ func (o *JSONOutput) Flush() {
 			Summary struct {
 				Valid int `json:"valid"`
 				Invalid int `json:"invalid"`
+				Errors int `json:"errors"`
 				Skipped int `json:"skipped"`
 			} `json:"summary"`
 		} {
@@ -59,6 +67,8 @@ func (o *JSONOutput) Flush() {
 				jsonObj.Summary.Valid++
 			case r.Status == "INVALID":
 				jsonObj.Summary.Invalid++
+			case r.Status == "ERROR":
+				jsonObj.Summary.Errors++
 			case r.Status == "SKIPPED":
 				jsonObj.Summary.Skipped++
 			}
diff --git a/pkg/output/text.go b/pkg/output/text.go
index bc21d59..96d4af3 100644
--- a/pkg/output/text.go
+++ b/pkg/output/text.go
@@ -7,11 +7,11 @@ import (
 
 type TextOutput struct {
 	withSummary                bool
-	nValid, nInvalid, nSkipped int
+	nValid, nInvalid, nErrors, nSkipped int
 }
 
 func NewTextOutput(withSummary bool) Output {
-	return &TextOutput{withSummary, 0,0,0}
+	return &TextOutput{withSummary, 0,0,0, 0}
 }
 
 func (o *TextOutput) Write(filename string,err error, skipped bool) {
@@ -22,11 +22,12 @@ func (o *TextOutput) Write(filename string,err error, skipped bool) {
 	}
 
 	if err != nil {
-		o.nInvalid++
 		if _, ok := err.(validator.InvalidResourceError); ok {
 			fmt.Printf("invalid resource: %s\n", err)
+			o.nInvalid++
 		} else {
 			fmt.Printf("failed validating resource in file %s: %s\n", filename, err)
+			o.nErrors++
 		}
 		return
 	}
@@ -39,7 +40,7 @@ func (o *TextOutput) Write(filename string,err error, skipped bool) {
 
 func (o *TextOutput) Flush() {
 	if o.withSummary {
-		fmt.Printf("Run summary - Valid: %d, Invalid: %d, Skipped: %d\n", o.nValid, o.nInvalid, o.nSkipped)
+		fmt.Printf("Run summary - Valid: %d, Invalid: %d, Errors: %d Skipped: %d\n", o.nValid, o.nInvalid, o.nErrors, o.nSkipped)
 	}
 }