From 44710f905376e06b3e0f1b1e9d3d8d448108a2ed Mon Sep 17 00:00:00 2001 From: Yann Hamon Date: Sun, 8 Nov 2020 16:50:21 +0100 Subject: [PATCH] cache http client in http registry --- pkg/registry/http.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/registry/http.go b/pkg/registry/http.go index a04f457..1f3307f 100644 --- a/pkg/registry/http.go +++ b/pkg/registry/http.go @@ -9,7 +9,7 @@ import ( ) type KubernetesRegistry struct { - http *http.Transport + c *http.Client schemaPathTemplate string strict bool } @@ -29,12 +29,13 @@ func newHTTPRegistry(schemaPathTemplate string, strict bool, skipTLS bool) *Kube IdleConnTimeout: 3 * time.Second, DisableCompression: true, } + if skipTLS { reghttp.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} } return &KubernetesRegistry{ - http: reghttp, + c: &http.Client{Transport: reghttp}, schemaPathTemplate: schemaPathTemplate, strict: strict, } @@ -46,8 +47,7 @@ func (r KubernetesRegistry) DownloadSchema(resourceKind, resourceAPIVersion, k8s return nil, err } - client := &http.Client{Transport: r.http} - resp, err := client.Get(url) + resp, err := r.c.Get(url) if err != nil { return nil, fmt.Errorf("failed downloading schema at %s: %s", url, err) }